Command refactor

This commit is contained in:
2022-05-15 21:42:01 +02:00
parent 9a99aad030
commit f99f90783f
42 changed files with 544 additions and 217 deletions

View File

@@ -0,0 +1,8 @@
namespace FileTime.App.Core.Models.Enums;
public enum PasteMode
{
Merge,
Overwrite,
Skip
}

View File

@@ -1,9 +0,0 @@
using FileTime.App.Core.Command;
namespace FileTime.App.Core.Services;
public interface ICommandHandler
{
bool CanHandleCommand(Command.Command command);
Task HandleCommandAsync(Command.Command command);
}

View File

@@ -1,8 +0,0 @@
using FileTime.App.Core.Command;
namespace FileTime.App.Core.Services;
public interface ICommandHandlerService
{
Task HandleCommandAsync(Command.Command command);
}

View File

@@ -0,0 +1,9 @@
using FileTime.App.Core.UserCommand;
namespace FileTime.App.Core.Services;
public interface IIdentifiableUserCommandService
{
void AddIdentifiableUserCommandFactory(string identifier, Func<IIdentifiableUserCommand> commandFactory);
IIdentifiableUserCommand GetCommand(string identifier);
}

View File

@@ -0,0 +1,9 @@
using FileTime.App.Core.UserCommand;
namespace FileTime.App.Core.Services;
public interface IUserCommandHandler
{
bool CanHandleCommand(IUserCommand command);
Task HandleCommandAsync(IUserCommand command);
}

View File

@@ -0,0 +1,7 @@
namespace FileTime.App.Core.Services;
public interface IUserCommandHandlerService
{
Task HandleCommandAsync(UserCommand.IUserCommand command);
Task HandleCommandAsync<TCommand>() where TCommand : UserCommand.IUserCommand, new();
}

View File

@@ -0,0 +1,13 @@
namespace FileTime.App.Core.UserCommand;
public class CloseTabCommand : IIdentifiableUserCommand
{
public const string CommandName = "close_tab";
public static CloseTabCommand Instance { get; } = new CloseTabCommand();
private CloseTabCommand()
{
}
public string UserCommandID => CommandName;
}

View File

@@ -0,0 +1,13 @@
namespace FileTime.App.Core.UserCommand;
public class CopyCommand : IIdentifiableUserCommand
{
public const string CommandName = "copy";
public static CopyCommand Instance { get; } = new CopyCommand();
private CopyCommand()
{
}
public string UserCommandID => CommandName;
}

View File

@@ -0,0 +1,13 @@
namespace FileTime.App.Core.UserCommand;
public class EnterRapidTravelCommand : IIdentifiableUserCommand
{
public const string CommandName = "exter_rapid_travel_mode";
public static EnterRapidTravelCommand Instance { get; } = new EnterRapidTravelCommand();
private EnterRapidTravelCommand()
{
}
public string UserCommandID => CommandName;
}

View File

@@ -0,0 +1,13 @@
namespace FileTime.App.Core.UserCommand;
public class ExitRapidTravelCommand : IIdentifiableUserCommand
{
public const string CommandName = "exit_rapid_travel_mode";
public static ExitRapidTravelCommand Instance { get; } = new ExitRapidTravelCommand();
private ExitRapidTravelCommand()
{
}
public string UserCommandID => CommandName;
}

View File

@@ -0,0 +1,13 @@
namespace FileTime.App.Core.UserCommand;
public class GoUpCommand : IIdentifiableUserCommand
{
public const string CommandName = "go_up";
public static GoUpCommand Instance { get; } = new GoUpCommand();
private GoUpCommand()
{
}
public string UserCommandID => CommandName;
}

View File

@@ -0,0 +1,6 @@
namespace FileTime.App.Core.UserCommand;
public interface IIdentifiableUserCommand : IUserCommand
{
string UserCommandID { get; }
}

View File

@@ -1,6 +1,11 @@
namespace FileTime.App.Core.Command; namespace FileTime.App.Core.UserCommand;
public enum Command public interface IUserCommand
{
}
/*public enum Command
{ {
None, None,
@@ -63,4 +68,4 @@ public enum Command
TimelineStart, TimelineStart,
ToggleAdvancedIcons, ToggleAdvancedIcons,
ToggleHidden, ToggleHidden,
} }*/

View File

@@ -0,0 +1,13 @@
namespace FileTime.App.Core.UserCommand;
public class MarkCommand : IIdentifiableUserCommand
{
public const string CommandName = "mark_selected";
public static MarkCommand Instance { get; } = new MarkCommand();
private MarkCommand()
{
}
public string UserCommandID => CommandName;
}

View File

@@ -0,0 +1,13 @@
namespace FileTime.App.Core.UserCommand;
public class MoveCursorDownCommand : IIdentifiableUserCommand
{
public const string CommandName = "move_cursor_down";
public static MoveCursorDownCommand Instance { get; } = new MoveCursorDownCommand();
private MoveCursorDownCommand()
{
}
public string UserCommandID => CommandName;
}

View File

@@ -0,0 +1,13 @@
namespace FileTime.App.Core.UserCommand;
public class MoveCursorUpCommand : IIdentifiableUserCommand
{
public const string CommandName = "move_cursor_up";
public static MoveCursorUpCommand Instance { get; } = new MoveCursorUpCommand();
private MoveCursorUpCommand()
{
}
public string UserCommandID => CommandName;
}

View File

@@ -0,0 +1,13 @@
using FileTime.Core.Models;
namespace FileTime.App.Core.UserCommand;
public class OpenContainerCommand : IUserCommand
{
public IAbsolutePath Path { get; }
private OpenContainerCommand(IAbsolutePath path)
{
Path = path;
}
}

View File

@@ -0,0 +1,13 @@
namespace FileTime.App.Core.UserCommand;
public class OpenSelectedCommand : IIdentifiableUserCommand
{
public const string CommandName = "open_selected";
public static OpenSelectedCommand Instance { get; } = new OpenSelectedCommand();
private OpenSelectedCommand()
{
}
public string UserCommandID => CommandName;
}

View File

@@ -0,0 +1,24 @@
using FileTime.App.Core.Models.Enums;
namespace FileTime.App.Core.UserCommand;
public class PasteCommand : IIdentifiableUserCommand
{
public const string PasteMergeCommandName = "paste_merge";
public const string PasteOverwriteCommandName = "paste_overwrite";
public const string PasteSkipCommandName = "paste_skip";
public static PasteCommand Merge { get; } = new PasteCommand(PasteMode.Merge, PasteMergeCommandName);
public static PasteCommand Overwrite { get; } = new PasteCommand(PasteMode.Overwrite, PasteOverwriteCommandName);
public static PasteCommand Skip { get; } = new PasteCommand(PasteMode.Skip, PasteSkipCommandName);
public PasteMode PasteMode { get; }
private PasteCommand(PasteMode pasteMode, string commandName)
{
PasteMode = pasteMode;
UserCommandID = commandName;
}
public string UserCommandID { get; }
}

View File

@@ -0,0 +1,34 @@
namespace FileTime.App.Core.UserCommand;
public class SwitchToTabCommand : IIdentifiableUserCommand
{
private const string SwitchToTabBase = "switch_to_tab";
public const string SwitchToTab1CommandName = SwitchToTabBase + "1";
public const string SwitchToTab2CommandName = SwitchToTabBase + "2";
public const string SwitchToTab3CommandName = SwitchToTabBase + "3";
public const string SwitchToTab4CommandName = SwitchToTabBase + "4";
public const string SwitchToTab5CommandName = SwitchToTabBase + "5";
public const string SwitchToTab6CommandName = SwitchToTabBase + "6";
public const string SwitchToTab7CommandName = SwitchToTabBase + "7";
public const string SwitchToTab8CommandName = SwitchToTabBase + "8";
public const string SwitchToLastTabCommandName = "switch_to_last_tab";
public static SwitchToTabCommand SwitchToTab1 { get; } = new(1, SwitchToTab1CommandName);
public static SwitchToTabCommand SwitchToTab2 { get; } = new(2, SwitchToTab2CommandName);
public static SwitchToTabCommand SwitchToTab3 { get; } = new(3, SwitchToTab3CommandName);
public static SwitchToTabCommand SwitchToTab4 { get; } = new(4, SwitchToTab4CommandName);
public static SwitchToTabCommand SwitchToTab5 { get; } = new(5, SwitchToTab5CommandName);
public static SwitchToTabCommand SwitchToTab6 { get; } = new(6, SwitchToTab6CommandName);
public static SwitchToTabCommand SwitchToTab7 { get; } = new(7, SwitchToTab7CommandName);
public static SwitchToTabCommand SwitchToTab8 { get; } = new(8, SwitchToTab8CommandName);
public static SwitchToTabCommand SwitchToLastTab { get; } = new(-1, SwitchToLastTabCommandName);
private SwitchToTabCommand(int tabNumber, string commandName)
{
TabNumber = tabNumber;
UserCommandID = commandName;
}
public string UserCommandID { get; }
public int TabNumber { get; }
}

View File

@@ -0,0 +1,19 @@
using FileTime.App.Core.UserCommand;
namespace FileTime.App.Core.Services.UserCommandHandler;
public class IdentifiableUserCommandService : IIdentifiableUserCommandService
{
private readonly Dictionary<string, Func<IIdentifiableUserCommand>> _identifiableUserCommands = new();
public void AddIdentifiableUserCommandFactory(string identifier, Func<IIdentifiableUserCommand> commandFactory)
=> _identifiableUserCommands.Add(identifier, commandFactory);
public IIdentifiableUserCommand GetCommand(string identifier)
{
if (!_identifiableUserCommands.ContainsKey(identifier))
throw new IndexOutOfRangeException($"No command factory is registered for command {identifier}");
return _identifiableUserCommands[identifier].Invoke();
}
}

View File

@@ -1,27 +1,28 @@
using System.Reactive.Linq; using System.Reactive.Linq;
using FileTime.App.Core.Command;
using FileTime.App.Core.Models; using FileTime.App.Core.Models;
using FileTime.App.Core.Models.Enums;
using FileTime.App.Core.UserCommand;
using FileTime.App.Core.ViewModels; using FileTime.App.Core.ViewModels;
using FileTime.Core.Command; using FileTime.Core.Command;
using FileTime.Core.Command.Copy;
using FileTime.Core.Models; using FileTime.Core.Models;
using CopyCommand = FileTime.Core.Command.Copy.CopyCommand;
namespace FileTime.App.Core.Services.CommandHandler; namespace FileTime.App.Core.Services.UserCommandHandler;
public class ItemManipulationCommandHandler : CommandHandlerBase public class ItemManipulationUserCommandHandlerService : UserCommandHandlerServiceBase
{ {
private ITabViewModel? _selectedTab; private ITabViewModel? _selectedTab;
private IItemViewModel? _currentSelectedItem; private IItemViewModel? _currentSelectedItem;
private readonly ICommandHandlerService _commandHandlerService; private readonly IUserCommandHandlerService _userCommandHandlerService;
private readonly IClipboardService _clipboardService; private readonly IClipboardService _clipboardService;
private readonly BindedCollection<IAbsolutePath>? _markedItems; private readonly BindedCollection<IAbsolutePath>? _markedItems;
public ItemManipulationCommandHandler( public ItemManipulationUserCommandHandlerService(
IAppState appState, IAppState appState,
ICommandHandlerService commandHandlerService, IUserCommandHandlerService userCommandHandlerService,
IClipboardService clipboardService) : base(appState) IClipboardService clipboardService) : base(appState)
{ {
_commandHandlerService = commandHandlerService; _userCommandHandlerService = userCommandHandlerService;
_clipboardService = clipboardService; _clipboardService = clipboardService;
SaveSelectedTab(t => _selectedTab = t); SaveSelectedTab(t => _selectedTab = t);
@@ -29,13 +30,11 @@ public class ItemManipulationCommandHandler : CommandHandlerBase
_markedItems = new BindedCollection<IAbsolutePath>(appState.SelectedTab.Select(t => t?.MarkedItems)); _markedItems = new BindedCollection<IAbsolutePath>(appState.SelectedTab.Select(t => t?.MarkedItems));
AddCommandHandlers(new (Command.Command, Func<Task>)[] AddCommandHandlers(new IUserCommandHandler[]
{ {
(Command.Command.Copy, Copy), new TypeUserCommandHandler<CopyCommand>(Copy),
(Command.Command.Mark, MarkItem), new TypeUserCommandHandler<MarkCommand>(MarkItem),
(Command.Command.PasteMerge, PasteMerge), new TypeUserCommandHandler<PasteCommand>(Paste),
(Command.Command.PasteOverwrite, PasteOverwrite),
(Command.Command.PasteSkip, PasteSkip),
}); });
} }
@@ -44,7 +43,7 @@ public class ItemManipulationCommandHandler : CommandHandlerBase
if (_selectedTab == null || _currentSelectedItem?.BaseItem?.FullName == null) return; if (_selectedTab == null || _currentSelectedItem?.BaseItem?.FullName == null) return;
_selectedTab.ToggleMarkedItem(new AbsolutePath(_currentSelectedItem.BaseItem)); _selectedTab.ToggleMarkedItem(new AbsolutePath(_currentSelectedItem.BaseItem));
await _commandHandlerService.HandleCommandAsync(Command.Command.MoveCursorDown); await _userCommandHandlerService.HandleCommandAsync(MoveCursorDownCommand.Instance);
} }
private Task Copy() private Task Copy()
@@ -69,6 +68,17 @@ public class ItemManipulationCommandHandler : CommandHandlerBase
return Task.CompletedTask; return Task.CompletedTask;
} }
private async Task Paste(PasteCommand command)
{
await (command.PasteMode switch
{
PasteMode.Merge => PasteMerge(),
PasteMode.Overwrite => PasteOverwrite(),
PasteMode.Skip => PasteSkip(),
_ => throw new ArgumentException($"Unknown {nameof(PasteMode)} value: {command.PasteMode}")
});
}
private async Task PasteMerge() private async Task PasteMerge()
{ {
await Paste(TransportMode.Merge); await Paste(TransportMode.Merge);

View File

@@ -1,37 +1,36 @@
using System.Reactive.Linq;
using FileTime.App.Core.Command;
using FileTime.App.Core.Extensions; using FileTime.App.Core.Extensions;
using FileTime.App.Core.Models.Enums; using FileTime.App.Core.Models.Enums;
using FileTime.App.Core.UserCommand;
using FileTime.App.Core.ViewModels; using FileTime.App.Core.ViewModels;
using FileTime.Core.Models; using FileTime.Core.Models;
using FileTime.Core.Services; using FileTime.Core.Services;
using FileTime.Providers.Local; using FileTime.Providers.Local;
using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.DependencyInjection;
namespace FileTime.App.Core.Services.CommandHandler; namespace FileTime.App.Core.Services.UserCommandHandler;
public class NavigationCommandHandler : CommandHandlerBase public class NavigationUserCommandHandlerService : UserCommandHandlerServiceBase
{ {
private readonly IAppState _appState; private readonly IAppState _appState;
private readonly IServiceProvider _serviceProvider; private readonly IServiceProvider _serviceProvider;
private readonly ILocalContentProvider _localContentProvider; private readonly ILocalContentProvider _localContentProvider;
private readonly ICommandHandlerService _commandHandlerService; private readonly IUserCommandHandlerService _userCommandHandlerService;
private ITabViewModel? _selectedTab; private ITabViewModel? _selectedTab;
private IContainer? _currentLocation; private IContainer? _currentLocation;
private IItemViewModel? _currentSelectedItem; private IItemViewModel? _currentSelectedItem;
private IEnumerable<IItemViewModel> _currentItems = Enumerable.Empty<IItemViewModel>(); private IEnumerable<IItemViewModel> _currentItems = Enumerable.Empty<IItemViewModel>();
private ViewMode _viewMode; private ViewMode _viewMode;
public NavigationCommandHandler( public NavigationUserCommandHandlerService(
IAppState appState, IAppState appState,
IServiceProvider serviceProvider, IServiceProvider serviceProvider,
ILocalContentProvider localContentProvider, ILocalContentProvider localContentProvider,
ICommandHandlerService commandHandlerService) : base(appState) IUserCommandHandlerService userCommandHandlerService) : base(appState)
{ {
_appState = appState; _appState = appState;
_serviceProvider = serviceProvider; _serviceProvider = serviceProvider;
_localContentProvider = localContentProvider; _localContentProvider = localContentProvider;
_commandHandlerService = commandHandlerService; _userCommandHandlerService = userCommandHandlerService;
SaveSelectedTab(t => _selectedTab = t); SaveSelectedTab(t => _selectedTab = t);
SaveCurrentSelectedItem(i => _currentSelectedItem = i); SaveCurrentSelectedItem(i => _currentSelectedItem = i);
@@ -40,24 +39,16 @@ public class NavigationCommandHandler : CommandHandlerBase
appState.ViewMode.Subscribe(v => _viewMode = v); appState.ViewMode.Subscribe(v => _viewMode = v);
AddCommandHandlers(new (Command.Command, Func<Task>)[] AddCommandHandlers(new IUserCommandHandler[]
{ {
(Command.Command.CloseTab, CloseTab), new TypeUserCommandHandler<CloseTabCommand>(CloseTab),
(Command.Command.EnterRapidTravel, EnterRapidTravel), new TypeUserCommandHandler<EnterRapidTravelCommand>(EnterRapidTravel),
(Command.Command.ExitRapidTravel, ExitRapidTravel), new TypeUserCommandHandler<ExitRapidTravelCommand>(ExitRapidTravel),
(Command.Command.GoUp, GoUp), new TypeUserCommandHandler<GoUpCommand>(GoUp),
(Command.Command.MoveCursorDown, MoveCursorDown), new TypeUserCommandHandler<MoveCursorDownCommand>(MoveCursorDown),
(Command.Command.MoveCursorUp, MoveCursorUp), new TypeUserCommandHandler<MoveCursorUpCommand>(MoveCursorUp),
(Command.Command.Open, OpenContainer), new TypeUserCommandHandler<OpenSelectedCommand>(OpenContainer),
(Command.Command.SwitchToLastTab, async () => await SwitchToTab(-1)), new TypeUserCommandHandler<SwitchToTabCommand>(SwitchToTab),
(Command.Command.SwitchToTab1, async () => await SwitchToTab(1)),
(Command.Command.SwitchToTab2, async () => await SwitchToTab(2)),
(Command.Command.SwitchToTab3, async () => await SwitchToTab(3)),
(Command.Command.SwitchToTab4, async () => await SwitchToTab(4)),
(Command.Command.SwitchToTab5, async () => await SwitchToTab(5)),
(Command.Command.SwitchToTab6, async () => await SwitchToTab(6)),
(Command.Command.SwitchToTab7, async () => await SwitchToTab(7)),
(Command.Command.SwitchToTab8, async () => await SwitchToTab(8)),
}); });
} }
@@ -109,8 +100,9 @@ public class NavigationCommandHandler : CommandHandlerBase
return Task.CompletedTask; return Task.CompletedTask;
} }
private Task SwitchToTab(int number) private Task SwitchToTab(SwitchToTabCommand command)
{ {
var number = command.TabNumber;
var tabViewModel = _appState.Tabs.FirstOrDefault(t => t.TabNumber == number); var tabViewModel = _appState.Tabs.FirstOrDefault(t => t.TabNumber == number);
if (number == -1) if (number == -1)
@@ -129,7 +121,7 @@ public class NavigationCommandHandler : CommandHandlerBase
if (_viewMode == ViewMode.RapidTravel) if (_viewMode == ViewMode.RapidTravel)
{ {
_commandHandlerService.HandleCommandAsync(Command.Command.ExitRapidTravel); _userCommandHandlerService.HandleCommandAsync(ExitRapidTravelCommand.Instance);
} }
_appState.SetSelectedTab(tabViewModel!); _appState.SetSelectedTab(tabViewModel!);

View File

@@ -0,0 +1,26 @@
using FileTime.App.Core.UserCommand;
namespace FileTime.App.Core.Services.UserCommandHandler;
public class TypeUserCommandHandler<T> : IUserCommandHandler
{
private readonly Func<T, Task> _handler;
public TypeUserCommandHandler(Func<T, Task> handler)
{
_handler = handler;
}
public TypeUserCommandHandler(Func<Task> handler)
{
_handler = async (_) => await handler();
}
public bool CanHandleCommand(IUserCommand command) => command is T;
public Task HandleCommandAsync(IUserCommand command)
{
if (command is not T typedCommand) throw new ArgumentException($"Parameter '{nameof(command)}' is not of type '{typeof(T).Name}'");
return _handler(typedCommand);
}
}

View File

@@ -0,0 +1,16 @@
namespace FileTime.App.Core.Services.UserCommandHandler;
public sealed class UserCommandHandler : IUserCommandHandler
{
private readonly Func<UserCommand.IUserCommand, bool> _canHandle;
private readonly Func<UserCommand.IUserCommand, Task> _handle;
public UserCommandHandler(Func<UserCommand.IUserCommand, bool> canHandle, Func<UserCommand.IUserCommand, Task> handle)
{
_canHandle = canHandle;
_handle = handle;
}
public bool CanHandleCommand(UserCommand.IUserCommand command) => _canHandle(command);
public async Task HandleCommandAsync(UserCommand.IUserCommand command) => await _handle(command);
}

View File

@@ -1,37 +1,44 @@
using System.Reactive.Linq; using System.Reactive.Linq;
using DynamicData; using DynamicData;
using FileTime.App.Core.Command;
using FileTime.App.Core.ViewModels; using FileTime.App.Core.ViewModels;
using FileTime.Core.Models; using FileTime.Core.Models;
namespace FileTime.App.Core.Services.CommandHandler; namespace FileTime.App.Core.Services.UserCommandHandler;
public abstract class CommandHandlerBase : ICommandHandler public abstract class UserCommandHandlerServiceBase : IUserCommandHandler
{ {
private readonly Dictionary<Command.Command, Func<Task>> _commandHandlers = new(); private readonly List<IUserCommandHandler> _userCommandHandlers = new();
private readonly IAppState? _appState; private readonly IAppState? _appState;
protected CommandHandlerBase(IAppState? appState = null) protected UserCommandHandlerServiceBase(IAppState? appState = null)
{ {
_appState = appState; _appState = appState;
} }
public bool CanHandleCommand(Command.Command command) => _commandHandlers.ContainsKey(command); public bool CanHandleCommand(UserCommand.IUserCommand command) => _userCommandHandlers.Any(h => h.CanHandleCommand(command));
public async Task HandleCommandAsync(Command.Command command) => await _commandHandlers[command].Invoke(); public async Task HandleCommandAsync(UserCommand.IUserCommand command)
protected void AddCommandHandler(Command.Command command, Func<Task> handler) => _commandHandlers.Add(command, handler);
protected void AddCommandHandlers(IEnumerable<(Command.Command command, Func<Task> handler)> commandHandlers)
{ {
foreach (var (command, handler) in commandHandlers) var handler = _userCommandHandlers.Find(h => h.CanHandleCommand(command));
if (handler is null) return;
await handler.HandleCommandAsync(command);
}
protected void AddCommandHandler(IUserCommandHandler userCommandHandler) => _userCommandHandlers.Add(userCommandHandler);
protected void AddCommandHandlers(IEnumerable<IUserCommandHandler> commandHandlers)
{
foreach (var userCommandHandler in commandHandlers)
{ {
AddCommandHandler(command, handler); AddCommandHandler(userCommandHandler);
} }
} }
protected void RemoveCommandHandler(Command.Command command) => _commandHandlers.Remove(command); protected void RemoveCommandHandler(IUserCommandHandler userCommandHandler) => _userCommandHandlers.Remove(userCommandHandler);
protected IDisposable SaveSelectedTab(Action<ITabViewModel?> handler) => RunWithAppState(appState => appState.SelectedTab.Subscribe(handler)); protected IDisposable SaveSelectedTab(Action<ITabViewModel?> handler) => RunWithAppState(appState => appState.SelectedTab.Subscribe(handler));
protected IDisposable SaveCurrentSelectedItem(Action<IItemViewModel?> handler) protected IDisposable SaveCurrentSelectedItem(Action<IItemViewModel?> handler)
=> RunWithAppState(appState => appState.SelectedTab.Select(t => t == null ? Observable.Return<IItemViewModel?>(null) : t.CurrentSelectedItem).Switch().Subscribe(handler)); => RunWithAppState(appState => appState.SelectedTab.Select(t => t == null ? Observable.Return<IItemViewModel?>(null) : t.CurrentSelectedItem).Switch().Subscribe(handler));
@@ -39,14 +46,14 @@ public abstract class CommandHandlerBase : ICommandHandler
=> RunWithAppState(appState => appState.SelectedTab.Select(t => t == null ? Observable.Return<IContainer?>(null) : t.CurrentLocation).Switch().Subscribe(handler)); => RunWithAppState(appState => appState.SelectedTab.Select(t => t == null ? Observable.Return<IContainer?>(null) : t.CurrentLocation).Switch().Subscribe(handler));
protected IDisposable SaveCurrentItems(Action<IEnumerable<IItemViewModel>> handler) protected IDisposable SaveCurrentItems(Action<IEnumerable<IItemViewModel>> handler)
=> RunWithAppState(appState => appState.SelectedTab.Select(t => t?.CurrentItemsCollectionObservable ?? Observable.Return((IEnumerable<IItemViewModel>?)Enumerable.Empty<IItemViewModel>())).Switch().Subscribe(i => handler(i ?? Enumerable.Empty<IItemViewModel>()))); => RunWithAppState(appState => appState.SelectedTab.Select(t => t?.CurrentItemsCollectionObservable ?? Observable.Return((IEnumerable<IItemViewModel>?) Enumerable.Empty<IItemViewModel>())).Switch().Subscribe(i => handler(i ?? Enumerable.Empty<IItemViewModel>())));
protected IDisposable SaveMarkedItems(Action<IChangeSet<IAbsolutePath>> handler) protected IDisposable SaveMarkedItems(Action<IChangeSet<IAbsolutePath>> handler)
=> RunWithAppState(appstate => appstate.SelectedTab.Select(t => t == null ? Observable.Empty<IChangeSet<IAbsolutePath>>() : t.MarkedItems).Switch().Subscribe(handler)); => RunWithAppState(appState => appState.SelectedTab.Select(t => t == null ? Observable.Empty<IChangeSet<IAbsolutePath>>() : t.MarkedItems).Switch().Subscribe(handler));
private IDisposable RunWithAppState(Func<IAppState, IDisposable> act) private IDisposable RunWithAppState(Func<IAppState, IDisposable> act)
{ {
if (_appState == null) throw new NullReferenceException($"AppState is nit initialized in {nameof(CommandHandlerBase)}."); if (_appState == null) throw new NullReferenceException($"AppState is nit initialized in {nameof(UserCommandHandlerServiceBase)}.");
return act(_appState); return act(_appState);
} }

View File

@@ -1,15 +1,14 @@
using FileTime.App.Core.Command;
using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.DependencyInjection;
namespace FileTime.App.Core.Services; namespace FileTime.App.Core.Services;
public class CommandHandlerService : ICommandHandlerService public class UserCommandHandlerService : IUserCommandHandlerService
{ {
private readonly Lazy<IEnumerable<ICommandHandler>> _commandHandlers; private readonly Lazy<IEnumerable<IUserCommandHandler>> _commandHandlers;
public CommandHandlerService(IServiceProvider serviceProvider) public UserCommandHandlerService(IServiceProvider serviceProvider)
{ {
_commandHandlers = new Lazy<IEnumerable<ICommandHandler>>(() => serviceProvider.GetServices<ICommandHandler>()); _commandHandlers = new Lazy<IEnumerable<IUserCommandHandler>>(serviceProvider.GetServices<IUserCommandHandler>);
//(Commands.AutoRefresh, ToggleAutoRefresh), //(Commands.AutoRefresh, ToggleAutoRefresh),
//(Commands.ChangeTimelineMode, ChangeTimelineMode), //(Commands.ChangeTimelineMode, ChangeTimelineMode),
@@ -67,7 +66,7 @@ public class CommandHandlerService : ICommandHandlerService
//(Commands.ToggleHidden, ToggleHidden), //(Commands.ToggleHidden, ToggleHidden),
} }
public async Task HandleCommandAsync(Command.Command command) public async Task HandleCommandAsync(UserCommand.IUserCommand command)
{ {
var handler = _commandHandlers.Value.FirstOrDefault(h => h.CanHandleCommand(command)); var handler = _commandHandlers.Value.FirstOrDefault(h => h.CanHandleCommand(command));
@@ -76,4 +75,7 @@ public class CommandHandlerService : ICommandHandlerService
await handler.HandleCommandAsync(command); await handler.HandleCommandAsync(command);
} }
} }
public async Task HandleCommandAsync<TUserCommand>() where TUserCommand : UserCommand.IUserCommand, new()
=> await HandleCommandAsync(new TUserCommand());
} }

View File

@@ -1,5 +1,6 @@
using FileTime.App.Core.Services; using FileTime.App.Core.Services;
using FileTime.App.Core.Services.CommandHandler; using FileTime.App.Core.Services.UserCommandHandler;
using FileTime.App.Core.StartupServices;
using FileTime.App.Core.ViewModels; using FileTime.App.Core.ViewModels;
using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.DependencyInjection;
@@ -14,15 +15,17 @@ public static class Startup
.AddTransient<IContainerViewModel, ContainerViewModel>() .AddTransient<IContainerViewModel, ContainerViewModel>()
.AddTransient<IElementViewModel, ElementViewModel>() .AddTransient<IElementViewModel, ElementViewModel>()
.AddTransient<IItemNameConverterService, ItemNameConverterService>() .AddTransient<IItemNameConverterService, ItemNameConverterService>()
.AddSingleton<ICommandHandlerService, CommandHandlerService>() .AddSingleton<IUserCommandHandlerService, UserCommandHandlerService>()
.AddSingleton<IClipboardService, ClipboardService>() .AddSingleton<IClipboardService, ClipboardService>()
.AddSingleton<IIdentifiableUserCommandService, IdentifiableUserCommandService>()
.AddSingleton<IStartupHandler, DefaultIdentifiableCommandHandlerRegister>()
.AddCommandHandlers(); .AddCommandHandlers();
} }
private static IServiceCollection AddCommandHandlers(this IServiceCollection serviceCollection) private static IServiceCollection AddCommandHandlers(this IServiceCollection serviceCollection)
{ {
return serviceCollection return serviceCollection
.AddSingleton<ICommandHandler, NavigationCommandHandler>() .AddSingleton<IUserCommandHandler, NavigationUserCommandHandlerService>()
.AddSingleton<ICommandHandler, ItemManipulationCommandHandler>(); .AddSingleton<IUserCommandHandler, ItemManipulationUserCommandHandlerService>();
} }
} }

View File

@@ -0,0 +1,39 @@
using FileTime.App.Core.Services;
using FileTime.App.Core.UserCommand;
namespace FileTime.App.Core.StartupServices;
public class DefaultIdentifiableCommandHandlerRegister : IStartupHandler
{
private readonly IIdentifiableUserCommandService _service;
public DefaultIdentifiableCommandHandlerRegister(IIdentifiableUserCommandService service)
{
_service = service;
AddUserCommand(CloseTabCommand.Instance);
AddUserCommand(CopyCommand.Instance);
AddUserCommand(EnterRapidTravelCommand.Instance);
AddUserCommand(ExitRapidTravelCommand.Instance);
AddUserCommand(GoUpCommand.Instance);
AddUserCommand(MarkCommand.Instance);
AddUserCommand(MoveCursorDownCommand.Instance);
AddUserCommand(MoveCursorUpCommand.Instance);
AddUserCommand(OpenSelectedCommand.Instance);
AddUserCommand(PasteCommand.Merge);
AddUserCommand(PasteCommand.Overwrite);
AddUserCommand(PasteCommand.Skip);
AddUserCommand(SwitchToTabCommand.SwitchToTab1);
AddUserCommand(SwitchToTabCommand.SwitchToTab2);
AddUserCommand(SwitchToTabCommand.SwitchToTab3);
AddUserCommand(SwitchToTabCommand.SwitchToTab4);
AddUserCommand(SwitchToTabCommand.SwitchToTab5);
AddUserCommand(SwitchToTabCommand.SwitchToTab6);
AddUserCommand(SwitchToTabCommand.SwitchToTab7);
AddUserCommand(SwitchToTabCommand.SwitchToTab8);
AddUserCommand(SwitchToTabCommand.SwitchToLastTab);
}
private void AddUserCommand(IIdentifiableUserCommand command)
=> _service.AddIdentifiableUserCommandFactory(command.UserCommandID, () => command);
}

View File

@@ -1,37 +1,40 @@
using Avalonia.Input; using Avalonia.Input;
using FileTime.App.Core.Command;
namespace FileTime.GuiApp.Configuration; namespace FileTime.GuiApp.Configuration;
public class CommandBindingConfiguration public class CommandBindingConfiguration
{ {
public List<KeyConfig> Keys { get; set; } = new List<KeyConfig>(); public List<KeyConfig> Keys { get; set; }
public Command Command { get; set; } = Command.None; public string Command { get; set; }
public string KeysDisplayText => GetKeysDisplayText(); public string KeysDisplayText => GetKeysDisplayText();
public CommandBindingConfiguration() { } public CommandBindingConfiguration()
{
Command = null!;
Keys = null!;
}
public CommandBindingConfiguration(Command command, IEnumerable<KeyConfig> keys) public CommandBindingConfiguration(string command, IEnumerable<KeyConfig> keys)
{ {
Keys = new List<KeyConfig>(keys); Keys = new List<KeyConfig>(keys);
Command = command; Command = command;
} }
public CommandBindingConfiguration(Command command, KeyConfig key) public CommandBindingConfiguration(string command, KeyConfig key)
{ {
Keys = new List<KeyConfig>() { key }; Keys = new List<KeyConfig>() { key };
Command = command; Command = command;
} }
public CommandBindingConfiguration(Command command, IEnumerable<Key> keys) public CommandBindingConfiguration(string command, IEnumerable<Key> keys)
{ {
Keys = keys.Select(k => new KeyConfig(k)).ToList(); Keys = keys.Select(k => new KeyConfig(k)).ToList();
Command = command; Command = command;
} }
public CommandBindingConfiguration(Command command, Key key) public CommandBindingConfiguration(string command, Key key)
{ {
Keys = new List<KeyConfig>() { new KeyConfig(key) }; Keys = new List<KeyConfig>() { new KeyConfig(key) };
Command = command; Command = command;
@@ -62,7 +65,7 @@ public class CommandBindingConfiguration
{ {
var s = ""; var s = "";
bool ctrlOrAlt = key.Ctrl || key.Alt; var ctrlOrAlt = key.Ctrl || key.Alt;
if (ctrlOrAlt && currentText.Length > 0 && currentText.Last() != ' ') s += " "; if (ctrlOrAlt && currentText.Length > 0 && currentText.Last() != ' ') s += " ";

View File

@@ -1,7 +1,5 @@
using Avalonia.Input; using Avalonia.Input;
using FileTime.App.Core.Command; using FileTime.App.Core.UserCommand;
using System;
using System.Collections.Generic;
namespace FileTime.GuiApp.Configuration; namespace FileTime.GuiApp.Configuration;
@@ -42,66 +40,66 @@ public static class MainConfiguration
{ {
return new List<CommandBindingConfiguration>() return new List<CommandBindingConfiguration>()
{ {
new CommandBindingConfiguration(Command.AutoRefresh, new KeyConfig(Key.R, shift: true)), //new CommandBindingConfiguration(ConfigCommand.AutoRefresh, new KeyConfig(Key.R, shift: true)),
new CommandBindingConfiguration(Command.ChangeTimelineMode, new[] { Key.T, Key.M }), //new CommandBindingConfiguration(ConfigCommand.ChangeTimelineMode, new[] { Key.T, Key.M }),
new CommandBindingConfiguration(Command.CloseTab, Key.Q), new CommandBindingConfiguration(CloseTabCommand.CommandName, Key.Q),
new CommandBindingConfiguration(Command.Compress, new[] { Key.Y, Key.C }), //new CommandBindingConfiguration(ConfigCommand.Compress, new[] { Key.Y, Key.C }),
new CommandBindingConfiguration(Command.Copy, new[] { Key.Y, Key.Y }), new CommandBindingConfiguration(CopyCommand.CommandName, new[] { Key.Y, Key.Y }),
new CommandBindingConfiguration(Command.CopyHash, new[] { Key.C, Key.H }), //new CommandBindingConfiguration(ConfigCommand.CopyHash, new[] { Key.C, Key.H }),
new CommandBindingConfiguration(Command.CopyPath, new[] { Key.C, Key.P }), //new CommandBindingConfiguration(ConfigCommand.CopyPath, new[] { Key.C, Key.P }),
new CommandBindingConfiguration(Command.CreateContainer, Key.F7), //new CommandBindingConfiguration(ConfigCommand.CreateContainer, Key.F7),
new CommandBindingConfiguration(Command.CreateContainer, new[] { Key.C, Key.C }), //new CommandBindingConfiguration(ConfigCommand.CreateContainer, new[] { Key.C, Key.C }),
new CommandBindingConfiguration(Command.CreateElement, new[] { Key.C, Key.E }), //new CommandBindingConfiguration(ConfigCommand.CreateElement, new[] { Key.C, Key.E }),
new CommandBindingConfiguration(Command.Cut, new[] { Key.D, Key.D }), //new CommandBindingConfiguration(ConfigCommand.Cut, new[] { Key.D, Key.D }),
new CommandBindingConfiguration(Command.Edit, new KeyConfig(Key.F4)), //new CommandBindingConfiguration(ConfigCommand.Edit, new KeyConfig(Key.F4)),
new CommandBindingConfiguration(Command.EnterRapidTravel, new KeyConfig(Key.OemComma, shift: true)), new CommandBindingConfiguration(EnterRapidTravelCommand.CommandName, new KeyConfig(Key.OemComma, shift: true)),
new CommandBindingConfiguration(Command.FindByName, new[] { Key.F, Key.N }), //new CommandBindingConfiguration(ConfigCommand.FindByName, new[] { Key.F, Key.N }),
new CommandBindingConfiguration(Command.FindByNameRegex, new[] { Key.F, Key.R }), //new CommandBindingConfiguration(ConfigCommand.FindByNameRegex, new[] { Key.F, Key.R }),
new CommandBindingConfiguration(Command.GoToHome, new[] { Key.G, Key.H }), //new CommandBindingConfiguration(ConfigCommand.GoToHome, new[] { Key.G, Key.H }),
new CommandBindingConfiguration(Command.GoToPath, new KeyConfig(Key.L, ctrl: true)), //new CommandBindingConfiguration(ConfigCommand.GoToPath, new KeyConfig(Key.L, ctrl: true)),
new CommandBindingConfiguration(Command.GoToPath, new[] { Key.G, Key.P }), //new CommandBindingConfiguration(ConfigCommand.GoToPath, new[] { Key.G, Key.P }),
new CommandBindingConfiguration(Command.GoToProvider, new[] { Key.G, Key.T }), //new CommandBindingConfiguration(ConfigCommand.GoToProvider, new[] { Key.G, Key.T }),
new CommandBindingConfiguration(Command.GoToRoot, new[] { Key.G, Key.R }), //new CommandBindingConfiguration(ConfigCommand.GoToRoot, new[] { Key.G, Key.R }),
new CommandBindingConfiguration(Command.HardDelete, new[] { new KeyConfig(Key.D,shift: true), new KeyConfig(Key.D, shift: true) }), //new CommandBindingConfiguration(ConfigCommand.HardDelete, new[] { new KeyConfig(Key.D,shift: true), new KeyConfig(Key.D, shift: true) }),
new CommandBindingConfiguration(Command.Mark, Key.Space), new CommandBindingConfiguration(MarkCommand.CommandName, Key.Space),
new CommandBindingConfiguration(Command.MoveToLast, new KeyConfig(Key.G, shift: true)), //new CommandBindingConfiguration(ConfigCommand.MoveToLast, new KeyConfig(Key.G, shift: true)),
new CommandBindingConfiguration(Command.MoveToFirst, new[] { Key.G, Key.G }), //new CommandBindingConfiguration(ConfigCommand.MoveToFirst, new[] { Key.G, Key.G }),
new CommandBindingConfiguration(Command.NextTimelineBlock, Key.L ), //new CommandBindingConfiguration(ConfigCommand.NextTimelineBlock, Key.L ),
new CommandBindingConfiguration(Command.NextTimelineCommand, Key.J ), //new CommandBindingConfiguration(ConfigCommand.NextTimelineCommand, Key.J ),
new CommandBindingConfiguration(Command.OpenInFileBrowser, new[] { Key.O, Key.E }), //new CommandBindingConfiguration(ConfigCommand.OpenInFileBrowser, new[] { Key.O, Key.E }),
new CommandBindingConfiguration(Command.PasteMerge, new[] { Key.P, Key.P }), new CommandBindingConfiguration(PasteCommand.PasteMergeCommandName, new[] { Key.P, Key.P }),
new CommandBindingConfiguration(Command.PasteOverwrite, new[] { Key.P, Key.O }), new CommandBindingConfiguration(PasteCommand.PasteOverwriteCommandName, new[] { Key.P, Key.O }),
new CommandBindingConfiguration(Command.PasteSkip, new[] { Key.P, Key.S }), new CommandBindingConfiguration(PasteCommand.PasteSkipCommandName, new[] { Key.P, Key.S }),
new CommandBindingConfiguration(Command.PinFavorite, new[] { Key.F, Key.P }), //new CommandBindingConfiguration(ConfigCommand.PinFavorite, new[] { Key.F, Key.P }),
new CommandBindingConfiguration(Command.PreviousTimelineBlock, Key.H ), //new CommandBindingConfiguration(ConfigCommand.PreviousTimelineBlock, Key.H ),
new CommandBindingConfiguration(Command.PreviousTimelineCommand, Key.K ), //new CommandBindingConfiguration(ConfigCommand.PreviousTimelineCommand, Key.K ),
new CommandBindingConfiguration(Command.Refresh, Key.R), //new CommandBindingConfiguration(ConfigCommand.Refresh, Key.R),
new CommandBindingConfiguration(Command.Rename, Key.F2), //new CommandBindingConfiguration(ConfigCommand.Rename, Key.F2),
new CommandBindingConfiguration(Command.Rename, new[] { Key.C, Key.W }), //new CommandBindingConfiguration(ConfigCommand.Rename, new[] { Key.C, Key.W }),
new CommandBindingConfiguration(Command.RunCommand, new KeyConfig(Key.D4, shift: true)), //new CommandBindingConfiguration(ConfigCommand.RunCommand, new KeyConfig(Key.D4, shift: true)),
new CommandBindingConfiguration(Command.ScanContainerSize, new[] { Key.C, Key.S }), //new CommandBindingConfiguration(ConfigCommand.ScanContainerSize, new[] { Key.C, Key.S }),
new CommandBindingConfiguration(Command.ShowAllShortcut, Key.F1), //new CommandBindingConfiguration(ConfigCommand.ShowAllShortcut, Key.F1),
new CommandBindingConfiguration(Command.SoftDelete, new[] { new KeyConfig(Key.D), new KeyConfig(Key.D, shift: true) }), //new CommandBindingConfiguration(ConfigCommand.SoftDelete, new[] { new KeyConfig(Key.D), new KeyConfig(Key.D, shift: true) }),
new CommandBindingConfiguration(Command.SwitchToLastTab, Key.D9), new CommandBindingConfiguration(SwitchToTabCommand.SwitchToLastTabCommandName, Key.D9),
new CommandBindingConfiguration(Command.SwitchToTab1, Key.D1), new CommandBindingConfiguration(SwitchToTabCommand.SwitchToTab1CommandName, Key.D1),
new CommandBindingConfiguration(Command.SwitchToTab2, Key.D2), new CommandBindingConfiguration(SwitchToTabCommand.SwitchToTab2CommandName, Key.D2),
new CommandBindingConfiguration(Command.SwitchToTab3, Key.D3), new CommandBindingConfiguration(SwitchToTabCommand.SwitchToTab3CommandName, Key.D3),
new CommandBindingConfiguration(Command.SwitchToTab4, Key.D4), new CommandBindingConfiguration(SwitchToTabCommand.SwitchToTab4CommandName, Key.D4),
new CommandBindingConfiguration(Command.SwitchToTab5, Key.D5), new CommandBindingConfiguration(SwitchToTabCommand.SwitchToTab5CommandName, Key.D5),
new CommandBindingConfiguration(Command.SwitchToTab6, Key.D6), new CommandBindingConfiguration(SwitchToTabCommand.SwitchToTab6CommandName, Key.D6),
new CommandBindingConfiguration(Command.SwitchToTab7, Key.D7), new CommandBindingConfiguration(SwitchToTabCommand.SwitchToTab7CommandName, Key.D7),
new CommandBindingConfiguration(Command.SwitchToTab8, Key.D8), new CommandBindingConfiguration(SwitchToTabCommand.SwitchToTab8CommandName, Key.D8),
new CommandBindingConfiguration(Command.TimelinePause, new[] { Key.T, Key.P }), //new CommandBindingConfiguration(ConfigCommand.TimelinePause, new[] { Key.T, Key.P }),
new CommandBindingConfiguration(Command.TimelineRefresh, new[] { Key.T, Key.R }), //new CommandBindingConfiguration(ConfigCommand.TimelineRefresh, new[] { Key.T, Key.R }),
new CommandBindingConfiguration(Command.TimelineStart, new[] { Key.T, Key.S }), //new CommandBindingConfiguration(ConfigCommand.TimelineStart, new[] { Key.T, Key.S }),
new CommandBindingConfiguration(Command.ToggleAdvancedIcons, new[] { Key.Z, Key.I }), //new CommandBindingConfiguration(ConfigCommand.ToggleAdvancedIcons, new[] { Key.Z, Key.I }),
new CommandBindingConfiguration(Command.GoUp, Key.Left), new CommandBindingConfiguration(GoUpCommand.CommandName, Key.Left),
new CommandBindingConfiguration(Command.Open, Key.Right), new CommandBindingConfiguration(OpenSelectedCommand.CommandName, Key.Right),
new CommandBindingConfiguration(Command.OpenOrRun, Key.Enter), //new CommandBindingConfiguration(ConfigCommand.OpenOrRun, Key.Enter),
new CommandBindingConfiguration(Command.MoveCursorUp, Key.Up), new CommandBindingConfiguration(MoveCursorUpCommand.CommandName, Key.Up),
new CommandBindingConfiguration(Command.MoveCursorDown, Key.Down), new CommandBindingConfiguration(MoveCursorDownCommand.CommandName, Key.Down),
new CommandBindingConfiguration(Command.MoveCursorUpPage, Key.PageUp), //new CommandBindingConfiguration(ConfigCommand.MoveCursorUpPage, Key.PageUp),
new CommandBindingConfiguration(Command.MoveCursorDownPage, Key.PageDown), //new CommandBindingConfiguration(ConfigCommand.MoveCursorDownPage, Key.PageDown),
}; };
} }

View File

@@ -1,5 +1,3 @@
using System.Collections.Generic;
namespace FileTime.GuiApp.Configuration; namespace FileTime.GuiApp.Configuration;
public class ProgramsConfiguration public class ProgramsConfiguration

View File

@@ -4,7 +4,7 @@ namespace FileTime.GuiApp.Services;
public interface IKeyboardConfigurationService public interface IKeyboardConfigurationService
{ {
IReadOnlyList<CommandBindingConfiguration> CommandBindings { get; } IReadOnlyDictionary<string, CommandBindingConfiguration> CommandBindings { get; }
IReadOnlyList<CommandBindingConfiguration> UniversalCommandBindings { get; } IReadOnlyDictionary<string, CommandBindingConfiguration> UniversalCommandBindings { get; }
IReadOnlyList<CommandBindingConfiguration> AllShortcut { get; } IReadOnlyDictionary<string, CommandBindingConfiguration> AllShortcut { get; }
} }

View File

@@ -1,4 +1,3 @@
using System.Collections.ObjectModel;
using FileTime.App.Core.Models; using FileTime.App.Core.Models;
using FileTime.App.Core.ViewModels; using FileTime.App.Core.ViewModels;
using FileTime.GuiApp.Configuration; using FileTime.GuiApp.Configuration;

View File

@@ -1,4 +1,3 @@
using System.Collections.ObjectModel;
using FileTime.App.Core.Models; using FileTime.App.Core.Models;
using FileTime.App.Core.ViewModels; using FileTime.App.Core.ViewModels;
using FileTime.GuiApp.Configuration; using FileTime.GuiApp.Configuration;

View File

@@ -1,6 +1,6 @@
using System.Globalization; using System.Globalization;
using Avalonia.Data.Converters; using Avalonia.Data.Converters;
using FileTime.App.Core.Command; using FileTime.App.Core.UserCommand;
namespace FileTime.GuiApp.Converters; namespace FileTime.GuiApp.Converters;
@@ -8,7 +8,7 @@ public class CommandToCommandNameConverter : IValueConverter
{ {
public object? Convert(object? value, Type targetType, object? parameter, CultureInfo culture) public object? Convert(object? value, Type targetType, object? parameter, CultureInfo culture)
{ {
if(value is not Command command) return value; if(value is not IUserCommand command) return value;
//TODO: implement //TODO: implement
return command.ToString(); return command.ToString();

View File

@@ -1,7 +1,7 @@
using System.Reactive.Linq; using System.Reactive.Linq;
using Avalonia.Input; using Avalonia.Input;
using FileTime.App.Core.Command;
using FileTime.App.Core.Services; using FileTime.App.Core.Services;
using FileTime.App.Core.UserCommand;
using FileTime.App.Core.ViewModels; using FileTime.App.Core.ViewModels;
using FileTime.Core.Models; using FileTime.Core.Models;
using FileTime.GuiApp.Configuration; using FileTime.GuiApp.Configuration;
@@ -20,18 +20,21 @@ public class DefaultModeKeyInputHandler : IDefaultModeKeyInputHandler
private ITabViewModel? _selectedTab; private ITabViewModel? _selectedTab;
private IContainer? _currentLocation; private IContainer? _currentLocation;
private readonly ILogger<DefaultModeKeyInputHandler> _logger; private readonly ILogger<DefaultModeKeyInputHandler> _logger;
private readonly ICommandHandlerService _commandHandlerService; private readonly IUserCommandHandlerService _userCommandHandlerService;
private readonly IIdentifiableUserCommandService _identifiableUserCommandService;
public DefaultModeKeyInputHandler( public DefaultModeKeyInputHandler(
IGuiAppState appState, IGuiAppState appState,
IKeyboardConfigurationService keyboardConfigurationService, IKeyboardConfigurationService keyboardConfigurationService,
ILogger<DefaultModeKeyInputHandler> logger, ILogger<DefaultModeKeyInputHandler> logger,
ICommandHandlerService commandHandlerService) IUserCommandHandlerService userCommandHandlerService,
IIdentifiableUserCommandService identifiableUserCommandService)
{ {
_appState = appState; _appState = appState;
_keyboardConfigurationService = keyboardConfigurationService; _keyboardConfigurationService = keyboardConfigurationService;
_logger = logger; _logger = logger;
_commandHandlerService = commandHandlerService; _userCommandHandlerService = userCommandHandlerService;
_identifiableUserCommandService = identifiableUserCommandService;
_appState.SelectedTab.Subscribe(t => _selectedTab = t); _appState.SelectedTab.Subscribe(t => _selectedTab = t);
_appState.SelectedTab.Select(t => t == null ? Observable.Return<IContainer?>(null) : t.CurrentLocation!).Switch().Subscribe(l => _currentLocation = l); _appState.SelectedTab.Select(t => t == null ? Observable.Return<IContainer?>(null) : t.CurrentLocation!).Switch().Subscribe(l => _currentLocation = l);
@@ -51,8 +54,8 @@ public class DefaultModeKeyInputHandler : IDefaultModeKeyInputHandler
var keyWithModifiers = new KeyConfig(key, shift: specialKeysStatus.IsShiftPressed, alt: specialKeysStatus.IsAltPressed, ctrl: specialKeysStatus.IsCtrlPressed); var keyWithModifiers = new KeyConfig(key, shift: specialKeysStatus.IsShiftPressed, alt: specialKeysStatus.IsAltPressed, ctrl: specialKeysStatus.IsCtrlPressed);
_appState.PreviousKeys.Add(keyWithModifiers); _appState.PreviousKeys.Add(keyWithModifiers);
var selectedCommandBinding = _keyboardConfigurationService.UniversalCommandBindings.FirstOrDefault(c => c.Keys.AreKeysEqual(_appState.PreviousKeys)); var selectedCommandBinding = _keyboardConfigurationService.UniversalCommandBindings.Values.FirstOrDefault(c => c.Keys.AreKeysEqual(_appState.PreviousKeys));
selectedCommandBinding ??= _keyboardConfigurationService.CommandBindings.FirstOrDefault(c => c.Keys.AreKeysEqual(_appState.PreviousKeys)); selectedCommandBinding ??= _keyboardConfigurationService.CommandBindings.Values.FirstOrDefault(c => c.Keys.AreKeysEqual(_appState.PreviousKeys));
if (key == Key.Escape) if (key == Key.Escape)
{ {
@@ -104,7 +107,7 @@ public class DefaultModeKeyInputHandler : IDefaultModeKeyInputHandler
setHandled(true); setHandled(true);
_appState.PreviousKeys.Clear(); _appState.PreviousKeys.Clear();
_appState.PossibleCommands = new(); _appState.PossibleCommands = new();
await CallCommandAsync(selectedCommandBinding.Command); await CallCommandAsync(_identifiableUserCommandService.GetCommand(selectedCommandBinding.Command));
} }
else if (_keysToSkip.Any(k => k.AreKeysEqual(_appState.PreviousKeys))) else if (_keysToSkip.Any(k => k.AreKeysEqual(_appState.PreviousKeys)))
{ {
@@ -122,7 +125,7 @@ public class DefaultModeKeyInputHandler : IDefaultModeKeyInputHandler
else else
{ {
setHandled(true); setHandled(true);
var possibleCommands = _keyboardConfigurationService.AllShortcut.Where(c => c.Keys[0].AreEquals(keyWithModifiers)).ToList(); var possibleCommands = _keyboardConfigurationService.AllShortcut.Values.Where(c => c.Keys[0].AreEquals(keyWithModifiers)).ToList();
if (possibleCommands.Count == 0) if (possibleCommands.Count == 0)
{ {
@@ -136,15 +139,15 @@ public class DefaultModeKeyInputHandler : IDefaultModeKeyInputHandler
} }
} }
private async Task CallCommandAsync(Command command) private async Task CallCommandAsync(IUserCommand command)
{ {
try try
{ {
await _commandHandlerService.HandleCommandAsync(command); await _userCommandHandlerService.HandleCommandAsync(command);
} }
catch (Exception e) catch (Exception e)
{ {
_logger.LogError(e, "Unknown error while running command. {Command} {Error}", command, e); _logger.LogError(e, "Unknown error while running command. {Command} {Error}", command.GetType().Name, e);
} }
} }
} }

View File

@@ -1,6 +1,5 @@
using Avalonia.Input; using Avalonia.Input;
using FileTime.App.Core.Models.Enums; using FileTime.App.Core.Models.Enums;
using FileTime.GuiApp.Configuration;
using FileTime.GuiApp.Models; using FileTime.GuiApp.Models;
using FileTime.GuiApp.ViewModels; using FileTime.GuiApp.ViewModels;

View File

@@ -1,4 +1,4 @@
using FileTime.App.Core.Command; using System.Collections.ObjectModel;
using FileTime.GuiApp.Configuration; using FileTime.GuiApp.Configuration;
using Microsoft.Extensions.Options; using Microsoft.Extensions.Options;
@@ -6,14 +6,14 @@ namespace FileTime.GuiApp.Services;
public class KeyboardConfigurationService : IKeyboardConfigurationService public class KeyboardConfigurationService : IKeyboardConfigurationService
{ {
public IReadOnlyList<CommandBindingConfiguration> CommandBindings { get; } public IReadOnlyDictionary<string, CommandBindingConfiguration> CommandBindings { get; }
public IReadOnlyList<CommandBindingConfiguration> UniversalCommandBindings { get; } public IReadOnlyDictionary<string, CommandBindingConfiguration> UniversalCommandBindings { get; }
public IReadOnlyList<CommandBindingConfiguration> AllShortcut { get; } public IReadOnlyDictionary<string, CommandBindingConfiguration> AllShortcut { get; }
public KeyboardConfigurationService(IOptions<KeyBindingConfiguration> keyBindingConfiguration) public KeyboardConfigurationService(IOptions<KeyBindingConfiguration> keyBindingConfiguration)
{ {
var commandBindings = new List<CommandBindingConfiguration>(); var commandBindings = new Dictionary<string, CommandBindingConfiguration>();
var universalCommandBindings = new List<CommandBindingConfiguration>(); var universalCommandBindings = new Dictionary<string, CommandBindingConfiguration>();
IEnumerable<CommandBindingConfiguration> keyBindings = keyBindingConfiguration.Value.KeyBindings; IEnumerable<CommandBindingConfiguration> keyBindings = keyBindingConfiguration.Value.KeyBindings;
if (keyBindingConfiguration.Value.UseDefaultBindings) if (keyBindingConfiguration.Value.UseDefaultBindings)
@@ -23,7 +23,7 @@ public class KeyboardConfigurationService : IKeyboardConfigurationService
foreach (var keyBinding in keyBindings) foreach (var keyBinding in keyBindings)
{ {
if (keyBinding.Command == Command.None) if (string.IsNullOrWhiteSpace(keyBinding.Command))
{ {
throw new FormatException($"No command is set in keybinding for keys '{keyBinding.KeysDisplayText}'"); throw new FormatException($"No command is set in keybinding for keys '{keyBinding.KeysDisplayText}'");
} }
@@ -34,21 +34,22 @@ public class KeyboardConfigurationService : IKeyboardConfigurationService
if (IsUniversal(keyBinding)) if (IsUniversal(keyBinding))
{ {
universalCommandBindings.Add(keyBinding); universalCommandBindings.Add(keyBinding.Command, keyBinding);
} }
else else
{ {
commandBindings.Add(keyBinding); commandBindings.Add(keyBinding.Command, keyBinding);
} }
} }
CommandBindings = commandBindings.AsReadOnly(); CommandBindings = new ReadOnlyDictionary<string, CommandBindingConfiguration>(commandBindings);
UniversalCommandBindings = universalCommandBindings.AsReadOnly(); UniversalCommandBindings = new ReadOnlyDictionary<string, CommandBindingConfiguration>(universalCommandBindings);
AllShortcut = new List<CommandBindingConfiguration>(CommandBindings.Concat(UniversalCommandBindings)).AsReadOnly(); AllShortcut = new ReadOnlyDictionary<string, CommandBindingConfiguration>(new Dictionary<string, CommandBindingConfiguration>(CommandBindings.Concat(UniversalCommandBindings)));
} }
private static bool IsUniversal(CommandBindingConfiguration keyMapping) private static bool IsUniversal(CommandBindingConfiguration keyMapping)
{ {
return keyMapping.Command is Command.GoUp or Command.Open or Command.OpenOrRun or Command.MoveCursorUp or Command.MoveCursorDown or Command.MoveCursorUpPage or Command.MoveCursorDownPage; return false;
//return keyMapping.Command is ConfigCommand.GoUp or ConfigCommand.Open or ConfigCommand.OpenOrRun or ConfigCommand.MoveCursorUp or ConfigCommand.MoveCursorDown or ConfigCommand.MoveCursorUpPage or ConfigCommand.MoveCursorDownPage;
} }
} }

View File

@@ -1,8 +1,7 @@
using Avalonia.Input; using Avalonia.Input;
using FileTime.App.Core.Command;
using FileTime.App.Core.Models; using FileTime.App.Core.Models;
using FileTime.App.Core.Models.Enums;
using FileTime.App.Core.Services; using FileTime.App.Core.Services;
using FileTime.App.Core.UserCommand;
using FileTime.App.Core.ViewModels; using FileTime.App.Core.ViewModels;
using FileTime.Core.Models; using FileTime.Core.Models;
using FileTime.Core.Services; using FileTime.Core.Services;
@@ -15,12 +14,14 @@ namespace FileTime.GuiApp.Services;
public class RapidTravelModeKeyInputHandler : IRapidTravelModeKeyInputHandler public class RapidTravelModeKeyInputHandler : IRapidTravelModeKeyInputHandler
{ {
private const string RAPIDTRAVELFILTERNAME = "rapid_travel_filter"; private const string RapidTravelFilterName = "rapid_travel_filter";
private readonly IAppState _appState; private readonly IAppState _appState;
private readonly IModalService _modalService; private readonly IModalService _modalService;
private readonly IKeyboardConfigurationService _keyboardConfigurationService; private readonly IKeyboardConfigurationService _keyboardConfigurationService;
private readonly ICommandHandlerService _commandHandlerService; private readonly IUserCommandHandlerService _userCommandHandlerService;
private readonly ILogger<RapidTravelModeKeyInputHandler> _logger; private readonly ILogger<RapidTravelModeKeyInputHandler> _logger;
private readonly IIdentifiableUserCommandService _identifiableUserCommandService;
private readonly BindedCollection<IModalViewModelBase> _openModals; private readonly BindedCollection<IModalViewModelBase> _openModals;
private ITabViewModel? _selectedTab; private ITabViewModel? _selectedTab;
@@ -28,15 +29,17 @@ public class RapidTravelModeKeyInputHandler : IRapidTravelModeKeyInputHandler
IAppState appState, IAppState appState,
IModalService modalService, IModalService modalService,
IKeyboardConfigurationService keyboardConfigurationService, IKeyboardConfigurationService keyboardConfigurationService,
ICommandHandlerService commandHandlerService, IUserCommandHandlerService userCommandHandlerService,
ILogger<RapidTravelModeKeyInputHandler> logger) ILogger<RapidTravelModeKeyInputHandler> logger,
IIdentifiableUserCommandService identifiableUserCommandService)
{ {
_appState = appState; _appState = appState;
_modalService = modalService; _modalService = modalService;
_keyboardConfigurationService = keyboardConfigurationService; _keyboardConfigurationService = keyboardConfigurationService;
_commandHandlerService = commandHandlerService; _userCommandHandlerService = userCommandHandlerService;
_logger = logger; _logger = logger;
_identifiableUserCommandService = identifiableUserCommandService;
_appState.SelectedTab.Subscribe(t => _selectedTab = t); _appState.SelectedTab.Subscribe(t => _selectedTab = t);
_openModals = new BindedCollection<IModalViewModelBase>(modalService.OpenModals); _openModals = new BindedCollection<IModalViewModelBase>(modalService.OpenModals);
@@ -56,7 +59,7 @@ public class RapidTravelModeKeyInputHandler : IRapidTravelModeKeyInputHandler
} }
else else
{ {
await CallCommandAsync(Command.ExitRapidTravel); await CallCommandAsync(ExitRapidTravelCommand.Instance);
} }
} }
else if (key == Key.Back) else if (key == Key.Back)
@@ -77,11 +80,11 @@ public class RapidTravelModeKeyInputHandler : IRapidTravelModeKeyInputHandler
else else
{ {
var currentKeyAsList = new List<KeyConfig>() {new KeyConfig(key)}; var currentKeyAsList = new List<KeyConfig>() {new KeyConfig(key)};
var selectedCommandBinding = _keyboardConfigurationService.UniversalCommandBindings.FirstOrDefault(c => c.Keys.AreKeysEqual(currentKeyAsList)); var selectedCommandBinding = _keyboardConfigurationService.UniversalCommandBindings.Values.FirstOrDefault(c => c.Keys.AreKeysEqual(currentKeyAsList));
if (selectedCommandBinding != null) if (selectedCommandBinding != null)
{ {
setHandled(true); setHandled(true);
await CallCommandAsync(selectedCommandBinding.Command); await CallCommandAsync(_identifiableUserCommandService.GetCommand(selectedCommandBinding.Command));
} }
} }
@@ -89,8 +92,8 @@ public class RapidTravelModeKeyInputHandler : IRapidTravelModeKeyInputHandler
{ {
if (_selectedTab?.Tab is not ITab tab) return; if (_selectedTab?.Tab is not ITab tab) return;
tab.RemoveItemFilter(RAPIDTRAVELFILTERNAME); tab.RemoveItemFilter(RapidTravelFilterName);
tab.AddItemFilter(new ItemFilter(RAPIDTRAVELFILTERNAME, i => i.Name.ToLower().Contains(_appState.RapidTravelText))); tab.AddItemFilter(new ItemFilter(RapidTravelFilterName, i => i.Name.ToLower().Contains(_appState.RapidTravelText)));
/*var currentLocation = await _appState.SelectedTab.CurrentLocation.Container.WithoutVirtualContainer(MainPageViewModel.RAPIDTRAVEL); /*var currentLocation = await _appState.SelectedTab.CurrentLocation.Container.WithoutVirtualContainer(MainPageViewModel.RAPIDTRAVEL);
var newLocation = new VirtualContainer( var newLocation = new VirtualContainer(
currentLocation, currentLocation,
@@ -122,15 +125,15 @@ public class RapidTravelModeKeyInputHandler : IRapidTravelModeKeyInputHandler
} }
} }
private async Task CallCommandAsync(Command command) private async Task CallCommandAsync(IUserCommand command)
{ {
try try
{ {
await _commandHandlerService.HandleCommandAsync(command); await _userCommandHandlerService.HandleCommandAsync(command);
} }
catch (Exception e) catch (Exception e)
{ {
_logger.LogError(e, "Unknown error while running command. {Command} {Error}", command, e); _logger.LogError(e, "Unknown error while running command. {Command} {Error}", command.GetType().Name, e);
} }
} }
} }

View File

@@ -1,7 +1,5 @@
using System; using System.Reflection;
using System.Reflection;
using Avalonia.Input; using Avalonia.Input;
using FileTime.App.Core;
using FileTime.App.Core.Services; using FileTime.App.Core.Services;
using FileTime.App.Core.ViewModels; using FileTime.App.Core.ViewModels;
using FileTime.Core.Models; using FileTime.Core.Models;
@@ -20,7 +18,7 @@ namespace FileTime.GuiApp.ViewModels;
[Inject(typeof(IServiceProvider), PropertyName = "_serviceProvider")] [Inject(typeof(IServiceProvider), PropertyName = "_serviceProvider")]
[Inject(typeof(ILogger<MainWindowViewModel>), PropertyName = "_logger")] [Inject(typeof(ILogger<MainWindowViewModel>), PropertyName = "_logger")]
[Inject(typeof(IKeyInputHandlerService), PropertyName = "_keyInputHandlerService")] [Inject(typeof(IKeyInputHandlerService), PropertyName = "_keyInputHandlerService")]
[Inject(typeof(ICommandHandlerService), PropertyAccessModifier = AccessModifier.Public)] [Inject(typeof(IUserCommandHandlerService), PropertyAccessModifier = AccessModifier.Public)]
[Inject(typeof(LifecycleService), PropertyName = "_lifecycleService")] [Inject(typeof(LifecycleService), PropertyName = "_lifecycleService")]
public partial class MainWindowViewModel : IMainWindowViewModelBase public partial class MainWindowViewModel : IMainWindowViewModelBase
{ {

View File

@@ -1,9 +1,6 @@
using System;
using Avalonia; using Avalonia;
using Avalonia.Controls; using Avalonia.Controls;
using Avalonia.Input; using Avalonia.Input;
using Avalonia.Markup.Xaml;
using Avalonia.Threading;
using FileTime.Core.Models; using FileTime.Core.Models;
using FileTime.GuiApp.Models; using FileTime.GuiApp.Models;
using FileTime.GuiApp.ViewModels; using FileTime.GuiApp.ViewModels;